-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds break
expressions
#62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 71.08% 71.34% +0.25%
==========================================
Files 106 106
Lines 6928 7073 +145
==========================================
+ Hits 4925 5046 +121
- Misses 2003 2027 +24
Continue to review full report at Codecov.
|
baszalmstra
force-pushed
the
break
branch
2 times, most recently
from
November 23, 2019 15:12
6ac5d7a
to
efc52b2
Compare
Wodann
reviewed
Nov 23, 2019
Wodann
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
break
expression to Mun. It allows breaking from loops and enables loops to have return types different fromnever
.The following code should work properly.
Here the
loop
should get theint
type instead of thenever
type due to thebreak a
statement.Depends on #60