Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better error message printing when signature is missing #80

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

baszalmstra
Copy link
Collaborator

Adds impl fmt::Display in the ABI autogen to get more correct descriptive error messages

@baszalmstra baszalmstra requested a review from Wodann January 12, 2020 10:45
@baszalmstra baszalmstra self-assigned this Jan 12, 2020
@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #80 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #80      +/-   ##
=========================================
- Coverage   74.75%   74.6%   -0.15%     
=========================================
  Files         117     117              
  Lines        8868    8885      +17     
=========================================
  Hits         6629    6629              
- Misses       2239    2256      +17
Impacted Files Coverage Δ
crates/mun_abi/src/autogen_impl.rs 94.28% <0%> (-4.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267f3c3...3d1c834. Read the comment docs.

@baszalmstra baszalmstra merged commit 473f480 into mun-lang:master Jan 12, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants