Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: garbage collector (defaults to mark&sweep) #99

Merged
merged 10 commits into from
Mar 26, 2020
Merged

feat: garbage collector (defaults to mark&sweep) #99

merged 10 commits into from
Mar 26, 2020

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Mar 19, 2020 •
edited
Loading

This PR adds simple garbage collection to Mun.

@baszalmstra baszalmstra self-assigned this Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #99 into master will increase coverage by 0.14%.
The diff coverage is 90.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   77.87%   78.02%   +0.14%     
==========================================
  Files         134      141       +7     
  Lines        8833     9034     +201     
==========================================
+ Hits         6879     7049     +170     
- Misses       1954     1985      +31
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/intrinsics.rs 96.66% <ø> (-0.40%) ⬇️
crates/mun_gc/src/root_ptr.rs 63.15% <63.15%> (ø)
crates/mun_runtime/src/struct.rs 87.91% <80.00%> (+0.41%) ⬆️
crates/mun_gc/src/mark_sweep.rs 83.75% <83.75%> (ø)
crates/mun_runtime/src/lib.rs 86.20% <92.30%> (-0.75%) ⬇️
crates/mun_gc/src/lib.rs 100.00% <100.00%> (ø)
crates/mun_gc/src/ptr.rs 100.00% <100.00%> (ø)
crates/mun_gc/tests/alloc.rs 100.00% <100.00%> (ø)
crates/mun_gc/tests/struct.rs 100.00% <100.00%> (ø)
crates/mun_gc/tests/util/mod.rs 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ad9b8...4f8e3bc. Read the comment docs.

@baszalmstra baszalmstra force-pushed the feature/gc branch 8 times, most recently from c4d9c0f to 3bd4397 Compare March 21, 2020 21:01
@baszalmstra baszalmstra requested a review from Wodann March 23, 2020 20:47
Wodann
Wodann requested changes Mar 24, 2020
View reviewed changes
Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👏 Good abstractions and well-implemented overall.

I do have some minor requests for changes.

crates/mun_gc/Cargo.toml Outdated Show resolved Hide resolved
crates/mun_gc/src/handle.rs Outdated Show resolved Hide resolved
crates/mun_gc/Cargo.toml Outdated Show resolved Hide resolved
crates/mun_gc/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_gc/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/struct.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/struct.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/struct.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/test.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra force-pushed the feature/gc branch 2 times, most recently from 2fcc6c9 to 0019773 Compare March 25, 2020 17:08
@baszalmstra baszalmstra changed the title WIP: Feature/gc Feature/gc Mar 25, 2020
Wodann
Wodann requested changes Mar 25, 2020
View reviewed changes
crates/mun_gc/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_gc/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_gc/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_gc/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_gc/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/garbage_collector.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/garbage_collector.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/struct.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/struct.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/struct.rs Outdated Show resolved Hide resolved
@Wodann Wodann merged commit 823cdc8 into mun-lang:master Mar 26, 2020
@Wodann Wodann changed the title Feature/gc feat: garbage collector (defaults to gc) Mar 26, 2020
@Wodann Wodann changed the title feat: garbage collector (defaults to gc) feat: garbage collector (defaults to mark&sweep) Mar 26, 2020
@Wodann
Copy link
Collaborator

Wodann commented Mar 27, 2020

Implement naive Garbage collection

@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wodann Wodann Wodann approved these changes

Assignees

@baszalmstra baszalmstra

Labels
None yet
Projects
None yet
Milestone
Mun v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@baszalmstra @Wodann