--list and --productid options added #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tperfitt in case you’re interested, my fork at https://github.com/grahampugh/macadmin-scripts already has —list and —build options. |
gregneagle
reviewed
Nov 3, 2019
| @@ -262,7 +262,7 @@ def replicate_url(full_url, | |||
| if attempt_resume: | |||
| curl_cmd.extend(['-C', '-']) | |||
| curl_cmd.append(full_url) | |||
| print("Downloading %s..." % full_url) | |||
| print("Downloading %s..." % full_url, file=sys.stderr) | |||
There was a problem hiding this comment.
Hmmm. I know why you want this; I just have a philosophical issue with directing non-error messages to stderr. Convince me this is the right thing to do. Is this a common pattern for UNIX/POSIX tools?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in the following options:
--list : output just a list of OS's and exit in plist format.
--productid: select the productid from the list
moved check for uid 0 to after check for list option since root is not required for that.
changed all info messages to stderr since stdout is used for outputting plist.