Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Roll Call Modal & Cards #5

Merged
merged 50 commits into from
Jan 5, 2021
Merged

Conversation

jamespurnama1
Copy link
Collaborator

@jamespurnama1 jamespurnama1 commented Sep 26, 2020

Components

Roll Call Component Changes:

  • Functioning responsive roll call modal.
  • Added GSAP Module to Votes Modal Component.

Card Stacks:

  • Re-usable Card Stacks Component through props.
  • Skip cards through clicking, dragging, scrolling, and arrow keys.
  • Includes:
  • Usage:
<CardStack 
  :delegates="delegatesDataArray"
  :active="activeDelegateNumber"
  desc="presence"
  progress="0.5"
  color="#FFF"
  time="30"
  yieldTo="USA"
/>
Prop Default Type Description Required?
delegates null Array The array of delegates. Yes
active 0 Number Index number for an array of delegates marking which delegate is active. Yes
desc '' String Set custom description. Use value presence to dynamically update with the country's presence. No
progress 0 Number/String Set custom card progress. Use value presence to dynamically update with the country's presence. No
color #5F78FF String Set custom progress color. No
time null Number Displays time and countdowns. Dynamically updates progress & desc prop. No
yieldTo null String Displays yield to information next to the time. Dynamically updates desc prop. Requires time prop. No

Global Changes

@vercel
Copy link

vercel bot commented Sep 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/munlite-team/munlite-frontend/ev53i733n
✅ Preview: https://munlite-frontend-git-ui-roll-call-modal.munlite-team.vercel.app

@jamespurnama1 jamespurnama1 changed the title UI roll call modal UI Roll Call Modal Sep 26, 2020
@kevin2000141
Copy link
Collaborator

@jamespurnama1 Just FYI, check responsiveness juga ya, cards yang belom jadi itu made my browser lag. Maybe we need to think of another alternative if this is not feasible

@kevin2000141
Copy link
Collaborator

@jamespurnama1 also, kedepannya PR kalo bisa spesifik aja, upgrade dependency dipisah PR ya, jadi banyak PR gpp

@kevin2000141
Copy link
Collaborator

@jamespurnama1 tests failed because of:

1) Roll Call Modal Test Redirects to GSL:
     CypressError: Timed out retrying: expected 'http://localhost:8080/delegates' to include '/gsl'

Comment on lines 11 to 19
<button @click="presence('Present')">
<p>Present</p>
</button>
<button @click="presence('Present & Voting')">
<p>Present<br>&amp; Voting</p>
</button>
<button @click="presence('Not Present')" id="notPresent">
<p>Not Present</p>
</button>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samanthatandrii ini click jalanin function methods tapi ga jalan.

@kevin2000141
Copy link
Collaborator

@jamespurnama1 please revert commit 565036d,

Files should have 644 permission if not executable, unless there is a specific reason.

@jamespurnama1 jamespurnama1 changed the title UI Roll Call Modal [WIP] UI Roll Call Modal & Cards Dec 10, 2020
@jamespurnama1
Copy link
Collaborator Author

jamespurnama1 commented Dec 19, 2020

Currently finished with some caveats:

  • Waiting for v-hotkey issue.
  • Needs a few tweaks for reusability in the future.

Copy link
Collaborator

@kevin2000141 kevin2000141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@samanthatandrii samanthatandrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamespurnama1 jamespurnama1 merged commit 36f5275 into development Jan 5, 2021
@jamespurnama1 jamespurnama1 deleted the ui-roll-call-modal branch March 3, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants