-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Roll Call Modal & Cards #5
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/munlite-team/munlite-frontend/ev53i733n |
@jamespurnama1 Just FYI, check responsiveness juga ya, cards yang belom jadi itu made my browser lag. Maybe we need to think of another alternative if this is not feasible |
@jamespurnama1 also, kedepannya PR kalo bisa spesifik aja, upgrade dependency dipisah PR ya, jadi banyak PR gpp |
@jamespurnama1 tests failed because of:
|
<button @click="presence('Present')"> | ||
<p>Present</p> | ||
</button> | ||
<button @click="presence('Present & Voting')"> | ||
<p>Present<br>& Voting</p> | ||
</button> | ||
<button @click="presence('Not Present')" id="notPresent"> | ||
<p>Not Present</p> | ||
</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samanthatandrii ini click jalanin function methods tapi ga jalan.
…munlite-frontend into ui-roll-call-modal
@jamespurnama1 please revert commit 565036d, Files should have 644 permission if not executable, unless there is a specific reason. |
Currently finished with some caveats:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Components
Roll Call Component Changes:
Card Stacks:
delegates
null
Array
active
0
Number
desc
''
String
presence
to dynamically update with the country's presence.progress
0
Number
/String
presence
to dynamically update with the country's presence.color
#5F78FF
String
time
null
Number
progress
&desc
prop.yieldTo
null
String
desc
prop. Requirestime
prop.Global Changes