Add PLEX_UID and PLEX_GID to support cross-fs (NFS) environments. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ever gonna get merged? |
|
+1 |
mcristina422
reviewed
May 9, 2020
| if cu, err := strconv.ParseBool(cleanUpPod); cu && err != nil { | ||
| log.Printf("Cleaning up pod...") | ||
| err = kubeClient.CoreV1().Pods(namespace).Delete(pod.Name, nil) | ||
| if err != nil { |
There was a problem hiding this comment.
You probably want to ignore IsNotFoundError
There was a problem hiding this comment.
Thanks for that. I'll change the logic to handle it.
|
Hey folks. I just finished a move, and am in the process of standing my homelab back up to play with this some more. I'll see if I can't carve out some time to fix this in the near future, and find a way to get the travis checks to pass and get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.