Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash on invalid formats #63

Closed
bojanz opened this issue Aug 26, 2021 · 2 comments
Closed

Don't crash on invalid formats #63

bojanz opened this issue Aug 26, 2021 · 2 comments

Comments

@bojanz
Copy link

bojanz commented Aug 26, 2021

Right now if the spec has an unrecognized format, "serve" will fail:

validating OpenAPI failed: invalid components: unsupported 'format' value "ulid"

OpenAPI considers the format to be freeform, a hint to clients, so we can afford to be less strict.

Kin has an option for this, so all it would take is to do:

	openapi3.SchemaFormatValidationDisabled = true

somewhere before openapi3.NewLoader().
@bwjohnson-ss
Copy link

This would help me too. Any progress?

strider2038 added a commit that referenced this issue Jul 19, 2022
@strider2038
#63 fix: don't crash on invalid formats
f59073f
@strider2038
Copy link
Collaborator

Fixed in v0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bojanz @strider2038 @bwjohnson-ss