fix(#71): naive fix excluding absolute path

[T1p0un3t]

No description provided.

[strider2038]

Hello! Thanks for PR. I think this check should be inside specificationURLIsRelativeFilename function.

func specificationURLIsRelativeFilename(filename string, fileConfig *fileConfiguration) bool {
	return filename != "" &&
		fileConfig.OpenAPI.SpecificationURL != "" &&
		!fileConfig.OpenAPI.urlFromEnv &&
		!strings.HasPrefix(fileConfig.OpenAPI.SpecificationURL, "/") &&
		!strings.HasPrefix(fileConfig.OpenAPI.SpecificationURL, "http")
}

[T1p0un3t]

Hello,

indeed it is easier to read and corresponds well to the need of the function.
Finaly the test is strings.HasPrefix(fileConfig.OpenAPI.SpecificationURL, "./")

Testing http and / is not useful just ./

func specificationURLIsRelativeFilename(filename string, fileConfig *fileConfiguration) bool {
	return filename != "" &&
		fileConfig.OpenAPI.SpecificationURL != "" &&
		!fileConfig.OpenAPI.urlFromEnv &&
		strings.HasPrefix(fileConfig.OpenAPI.SpecificationURL, "./")
}

I have a question : in this case is prefixing with the directory a good solution? (filepath.Dir(filename) + "/") ?

[strider2038]

Testing http and / is not useful just ./

I agree.

I have a question : in this case is prefixing with the directory a good solution? (filepath.Dir(filename) + "/") ?

I think if the path is relative, then it is expected to be relative to the configuration file, but not relative to the working directory. For example, if you run docker compose from another directory, all paths will be relative to the configuration file.

[T1p0un3t]

Ok, I hadn't thought of that scenario.
So perhaps the information on the documentation should be added to clarify this. I will create a ticket for this.

I updated the code to test if the path starts with ./ .

Thanks