fix docker multi-arch build and push to DockerHub #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoench
changed the title
|
@strider2038 @lucasantarella can you may have a look at this PR? Thanks in advance :-) |
|
Could you merge this, please. |
|
+1 Merge please |
|
Now it fails on go build https://github.com/muonsoft/openapi-mock/actions/runs/3575788220/jobs/6012771527 |
|
The Dockerfile is not ready for multiarch. GOARCH is set to amd64 needs to be changed to target platform |
|
Possible solution (see https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/#949e): FROM --platform=$BUILDPLATFORM golang:alpine AS build-env
....
ARG TARGETOS TARGETARCH
RUN ...
&& CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -ldflags="-w -s -X main.version=${APP_VERSION} -X main.buildTime=${BUILD_TIME}" -o openapi-mock \
....If I get the chance, I will provide a PR.... |
mbana
added a commit
to kubeshop/kusk-gateway
that referenced
this pull request
Dec 6, 2022
Summary ======= 1. Upgrade `muonsoft/openapi-mock` image to `0.3.8` so that `linux/arm64` is supported. 2. Change to fully qualified image name `docker.io/muonsoft/openapi-mock`. 3. Upgrade `github.com/getkin/kin-openapi` to `v0.110.0`. Changes ======= `go.mod` and `go.sum` --------------------- Upgrade `github.com/getkin/kin-openapi` to `v0.110.0`. `cmd/kusk/internal/mocking/server/server.go` -------------------------------------------- Upgrade `muonsoft/openapi-mock` image to `0.3.8` that supports: * `linux/amd64` * `linux/arm64` See https://hub.docker.com/layers/muonsoft/openapi-mock/0.3.8/images/sha256-63b97f13af19dc164d2e005be28224152c05187f7a523fee971b6c44f6316f9b?context=explore and [1]. References ========== [1]: muonsoft/openapi-mock#80. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
mbana
added a commit
to kubeshop/kusk-gateway
that referenced
this pull request
Dec 6, 2022
Summary ======= 1. Upgrade `muonsoft/openapi-mock` image to `0.3.8` so that `linux/arm64` is supported. 2. Change to fully qualified image name `docker.io/muonsoft/openapi-mock`. 3. Upgrade `github.com/getkin/kin-openapi` to `v0.110.0`. Changes ======= `go.mod` and `go.sum` --------------------- Upgrade `github.com/getkin/kin-openapi` to `v0.110.0`, and also ran `go mod tidy`. `cmd/kusk/internal/mocking/server/server.go` -------------------------------------------- Upgrade `muonsoft/openapi-mock` image to `0.3.8` that supports: * `linux/amd64` * `linux/arm64` See https://hub.docker.com/layers/muonsoft/openapi-mock/0.3.8/images/sha256-63b97f13af19dc164d2e005be28224152c05187f7a523fee971b6c44f6316f9b?context=explore and [1]. References ========== [1]: muonsoft/openapi-mock#80. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
mbana
added a commit
to kubeshop/kusk-gateway
that referenced
this pull request
Dec 6, 2022
Summary ======= 1. Upgrade `muonsoft/openapi-mock` image to `0.3.8` so that `linux/arm64` is supported. 2. Change to fully qualified image name `docker.io/muonsoft/openapi-mock`. 3. Upgrade `github.com/getkin/kin-openapi` to `v0.110.0`. Changes ======= `go.mod` and `go.sum` --------------------- Upgrade `github.com/getkin/kin-openapi` to `v0.110.0`, and also ran `go mod tidy`. `cmd/kusk/internal/mocking/server/server.go` -------------------------------------------- Upgrade `muonsoft/openapi-mock` image to `0.3.8` that supports: * `linux/amd64` * `linux/arm64` See https://hub.docker.com/layers/muonsoft/openapi-mock/0.3.8/images/sha256-63b97f13af19dc164d2e005be28224152c05187f7a523fee971b6c44f6316f9b?context=explore and [1]. References ========== [1]: muonsoft/openapi-mock#80. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋 ,
I saw there is a failing build and push of the docker image to DockerHub.
In the recent version 3 of the
docker/build-push-actionthe configuration changed a bit.I updated the workflow to work with latest version and as it is proposed here.
I couldn't test it but I'm using a similar configuration to build and push my docker multi-arch images to DockerHub.