pqm4 V2 #78
Merged
pqm4 V2 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dev references
By not using SRAM2 we get more consistent benchmarks since SRAM2 seems to slow down memory accesses. This lead to schemes that are wasteful with stack (i.e., overflowing the 16 KiB SRAM2 into SRAM1) were faster.
As a bonus, includes build_everything.py
* hashing benchmarks * some more refactoring * sample benchmarks * sample benchmarks * new benchmarks * fix kyber1024 benchmarks
* hashing benchmarks * some more refactoring * sample benchmarks * sample benchmarks * namespacing for pqclean * namespacing in testvectors on host * Integrate PQClean's AES into pqm4 * Fix path for host sources in Makefile * Update mupq * Fix bug in testvectors AES-128 * Add optimized AES-192/256 implementations. Round-2-Kyber will use this. Everything is put into separate sections such that the linker with gc-sections will succesfully throw out an AES instance (or all of them) whenever it is not used by a scheme. * Update mupq * fix incremental keccak implementation * added benchmarks for ntruhps2048509 and sphincs-shake256-128f-simple * make frodo scheme naming consistent with PQClean (breaks testvectors) * rename frodo in benchmark results
This was referenced May 1, 2019
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is almost ready to be merged back to master. The most important changes are:
Are there any important features missing that we should still add for round 2?
If not, I'll rewrite the README to include these changes. It's slightly messy since we now have round1 and round2 implementations and the migration will still take a while. So we'll have to document this properly.