Skip to content

fix: parameter and return type bugs in peer connection wrapper #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2025
Merged

fix: parameter and return type bugs in peer connection wrapper #368

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd86d2f
fix: use correct parameter index for mid in addRemoteCandidate
mertushka Aug 10, 2025
45d1647
fix: password was being assigned to username variable
mertushka Aug 10, 2025
24113fb
fix: wrong return type in maxMessageSize
mertushka Aug 10, 2025
1c8c5ca
fix: remove negation from unordered parameter
mertushka Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/cpp/peer-connection-wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ PeerConnectionWrapper::PeerConnectionWrapper(const Napi::CallbackInfo &info)
if (proxyServer.Get("username").IsString())
username = proxyServer.Get("username").As<Napi::String>().ToString();
if (proxyServer.Get("password").IsString())
username = proxyServer.Get("password").As<Napi::String>().ToString();
password = proxyServer.Get("password").As<Napi::String>().ToString();

rtcConfig.proxyServer = rtc::ProxyServer(type, ip, port, username, password);
}
Expand Down Expand Up @@ -503,7 +503,7 @@ void PeerConnectionWrapper::addRemoteCandidate(const Napi::CallbackInfo &info)
try
{
std::string candidate = info[0].As<Napi::String>().ToString();
std::string mid = info[0].As<Napi::String>().ToString();
std::string mid = info[1].As<Napi::String>().ToString();
mRtcPeerConnPtr->addRemoteCandidate(rtc::Candidate(candidate, mid));
}
catch (std::exception &ex)
Expand Down Expand Up @@ -582,7 +582,7 @@ Napi::Value PeerConnectionWrapper::createDataChannel(const Napi::CallbackInfo &i
Napi::TypeError::New(env, "Wrong DataChannel Init Config (unordered)").ThrowAsJavaScriptException();
return info.Env().Null();
}
init.reliability.unordered = !initConfig.Get("unordered").As<Napi::Boolean>();
init.reliability.unordered = initConfig.Get("unordered").As<Napi::Boolean>();
}

if (!initConfig.Get("maxPacketLifeTime").IsUndefined() && !initConfig.Get("maxPacketLifeTime").IsNull() &&
Expand Down Expand Up @@ -1087,7 +1087,7 @@ Napi::Value PeerConnectionWrapper::maxMessageSize(const Napi::CallbackInfo &info

try
{
return Napi::Array::New(env, mRtcPeerConnPtr->remoteMaxMessageSize());
return Napi::Number::New(env, mRtcPeerConnPtr->remoteMaxMessageSize());
}
catch (std::exception &ex)
{
Expand Down