Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy support #72

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Ivy support #72

merged 2 commits into from
Jul 5, 2023

Conversation

yuri-apanasik
Copy link
Contributor

Here is minimal changes to support Angular 16 (View Engine support was removed in this version, so Ivy distribution is required).
Please, check the possibility to merge the PR and release new version on NPM.
I am open to add some more adjustments if needed.
Thank you.

@yuri-apanasik
Copy link
Contributor Author

@muratcorlu using your library with Angular 16 is not possible now because of missing Ivy support

@muratcorlu
Copy link
Owner

Hi @yuri-apanasik! Thanks for the contribution. I'm not able to use Angular a lot for a few years, so I lost track of new features. I would like to provide an update for this library for sure. But with this PR, library will not able to work with the version prior to 16, right? Can we cover a broader range of Angular versions? #65 suggests Angular 13 or newer would be enough, if I don't understand wrong. Maybe @inorganik can comment as well?

@inorganik
Copy link

Hi @muratcorlu, he is right; looks like this lib was last current with Angular 11 so it will need to be updated to be compatible with v16 and newer since ngcc compiler (view engine) is no longer supported. It's just a matter of updating the project, which it looks like that's all he did. Angular began using ivy by default in v13 I think.

Ivy-compiled libs should be supported as far back as v9. But that's ok - bump the major version of this package to 16 (it's easiest for developers to see compatibility) before you publish. Then you can direct devs who need to support 8 and older to use whichever version is currently published.

@yuri-apanasik yuri-apanasik changed the title Angular 16 support Ivy support Jul 5, 2023
@yuri-apanasik
Copy link
Contributor Author

@muratcorlu @inorganik changed to 13+ peer dependency
In addition I've replaced tslint with eslint (first one is no longer supported), removed default e2e project (looks like it was not used anyway), used new build with my application (where we used your library and what we can't update to Angular 16 now) - it was ok.
But sure it is better to double check. Would be so good if you will find time to check if everything is ok and publish new version.

Copy link
Owner

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Let me merge and release this with a major version. If we notice any problem, we can make patch releases as well. Thanks for your help!

@muratcorlu muratcorlu merged commit 001a7a7 into muratcorlu:master Jul 5, 2023
@muratcorlu
Copy link
Owner

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yuri-apanasik
Copy link
Contributor Author

Thank you for the quick reply! We will use new version in our application ...right now :) So, I'll give you know in case any troubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants