[ci skip] try Lachlan's vite plugin #103
Conversation
muratkeremozcan
commented
Apr 19, 2023
•
muratkeremozcan
commented
| @@ -42,17 +42,18 @@ | |||
| "react-icons": "4.8.0", | |||
| "react-query": "3.39.3", | |||
| "react-router-dom": "6.10.0", | |||
| "react-scripts": "5.0.1", | |||
There was a problem hiding this comment.
realized I left this here before...
vite.config.ts
Outdated
| @@ -3,6 +3,7 @@ import path from 'path' | |||
| import react from '@vitejs/plugin-react' // cy code cov | |||
| import istanbul from 'vite-plugin-istanbul' // cy code cov | |||
| import EnvironmentPlugin from 'vite-plugin-environment' // to be able to use process.env. | |||
| import {CypressMocks} from '@lmiller1990/vite-plugin-proxify-esm' | |||
There was a problem hiding this comment.
@lmiller1990 is this how we use it?
|
Looks like we have some bugs still. I fixed this one, but now:
For reference, fix: cypress-io/cypress@befd9dc#diff-22e277a2300647e6ce61bd2e48e980556314105f2c7b5c47306d1e25d1412411R57 |
src/About.tsx
Outdated
| consistent in their styles and design decisions. This one inspires from | ||
| them, uses CCTDD and takes variances along the way. | ||
| </p> | ||
| function About() { |
There was a problem hiding this comment.
I'm not sure why, but this was giving me issues. I had to change from const to function and it works.
I think React Router does something unusual under-the-hood with lazy, I am not sure what, but I'll look into it. Using const with the plugin causes a very weird error.
There was a problem hiding this comment.
It's better to use named functions for stack trace anyway, but it would be nice if at work we didn't have to change a few hundred of them from anonymous to named.
| @@ -16,6 +17,9 @@ export default defineConfig({ | |||
| requireEnv: false, | |||
| }), | |||
| EnvironmentPlugin(['VITE_API_URL']), | |||
| CypressEsm({ | |||
| ignoreList: ['*react*'], | |||
There was a problem hiding this comment.
Info on ignoreList in the readme: https://github.com/cypress-io/cypress/blob/6a4665cf49819714b40f7c0a3aa17f8e97442da2/npm/vite-plugin-cypress-esm/README.md#react-router-and-lazy-routes-issue
Basically we wrap all modules in a Proxy to allow Sinon to stub/spy. Some libraries do not seem to play nicely with Proxy. Also, it can incur some performance overhead. This opts out of the Proxy ES module runtime. I'm thinking you don't generally want to stub things like your code modules anyway, like Router etc - so I think this is okay.
Long term, we will make sure all the modules work as expected, so this won't be needed.
Passing run #579 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 96.70% 96.89% +0.18%
==========================================
Files 33 33
Lines 516 515 -1
Branches 67 66 -1
==========================================
Hits 499 499
+ Misses 17 16 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
