Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): add opus codec support #133

Merged
merged 1 commit into from
Feb 5, 2024
Merged

feat(v2): add opus codec support #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions schema/conversionSettings.schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { z } from 'zod';

export const codecSchema = z.enum(['default', 'aac', 'ac3', 'eac3']);
export const codecSchema = z.enum(['default', 'aac', 'ac3', 'eac3', 'libopus']);
export type Codec = z.infer<typeof codecSchema>;

export const bitrateSchema = z.enum([
Expand All @@ -22,7 +22,18 @@ export const bitrateSchema = z.enum([
]);
export type Bitrate = z.infer<typeof bitrateSchema>;

export const sampleRateSchema = z.enum(['default', '8000', '22050', '32000', '44100', '48000', '96000']);
export const sampleRateSchema = z.enum([
'default',
'8000',
'12000',
'16000',
'22050',
'24000',
'32000',
'44100',
'48000',
'96000',
]);
export type SampleRate = z.infer<typeof sampleRateSchema>;

export const channelsSchema = z.enum(['default', '1', '2', '3', '4', '5', '6', '7', '8']);
Expand Down
1 change: 1 addition & 0 deletions src/components/ConversionSettingsForm/BitrateSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const bitrateByCodec: Record<Codec, Bitrate[]> = {
aac: ['default', '32k', '64k', '96k', '128k', '192k', '256k', '320k'],
ac3: ['default', '128k', '192k', '256k', '320k', '384k', '448k', '512k', '640k'],
eac3: ['default', '192k', '320k', '448k', '640k', '1024k', '2048k', '4096k'],
libopus: ['default', '32k', '64k', '96k', '128k', '192k', '256k', '320k', '448k'],
};

export const BitrateSelect = ({ codec, isDisabled, value, onChange }: BitrateSelectProps) => {
Expand Down
1 change: 1 addition & 0 deletions src/components/ConversionSettingsForm/ChannelsSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const channelsByCodec: Record<Codec, Channels[]> = {
aac: ['default', '1', '2', '3', '4', '5', '6', '7', '8'],
ac3: ['default', '1', '2', '3', '4', '5', '6'],
eac3: ['default', '1', '2', '3', '4', '5', '6'],
libopus: ['default', '1', '2', '3', '4', '5', '6', '7', '8'],
};

export const ChannelsSelect = ({ isDisabled, codec, onChange, value }: ChannelsSelectProps) => {
Expand Down
1 change: 1 addition & 0 deletions src/components/ConversionSettingsForm/SampleRateSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const sampleRateByCodec: Record<Codec, SampleRate[]> = {
aac: ['default', '8000', '22050', '32000', '44100', '48000', '96000'],
ac3: ['default', '8000', '22050', '32000', '44100', '48000'],
eac3: ['default', '32000', '44100', '48000'],
libopus: ['default', '8000', '12000', '16000', '24000', '48000'],
};

export const SampleRateSelect = ({ codec, isDisabled, onChange, value }: SampleRateSelectProps) => {
Expand Down
6 changes: 5 additions & 1 deletion src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,19 @@
"default": "No re-encoding",
"aac": "AAC",
"ac3": "AC3",
"eac3": "EAC3"
"eac3": "EAC3",
"libopus": "Opus"
}
},
"sampleRate": {
"label": "Sample rate",
"values": {
"default": "Same as source",
"8000": "8000 Hz",
"12000": "12000 Hz",
"16000": "16000 Hz",
"22050": "22050 Hz",
"24000": "24000 Hz",
"32000": "32000 Hz",
"44100": "44100 Hz",
"48000": "48000 Hz",
Expand Down
6 changes: 5 additions & 1 deletion src/i18n/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,19 @@
"default": "Pas de réencodage",
"aac": "AAC",
"ac3": "AC3",
"eac3": "EAC3"
"eac3": "EAC3",
"libopus": "Opus"
}
},
"sampleRate": {
"label": "Fréquence d'échantillonnage",
"values": {
"default": "Identique à la source",
"8000": "8000 Hz",
"12000": "12000 Hz",
"16000": "16000 Hz",
"22050": "22050 Hz",
"24000": "24000 Hz",
"32000": "32000 Hz",
"44100": "44100 Hz",
"48000": "48000 Hz",
Expand Down
Loading