Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 264.line breakpoint function module #17

Merged
merged 33 commits into from
Mar 24, 2019
Merged

Create 264.line breakpoint function module #17

merged 33 commits into from
Mar 24, 2019

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 29, 2019

Closes #6

@delucis delucis requested a review from jsbean January 30, 2019 00:10
@delucis
Copy link
Member Author

delucis commented Jan 30, 2019

@jsbean Would you mind pulling this PR branch and seeing if the new 264.line module works well on your end?

I think the following should do it:

cd ~/Documents/Max\ 7/Packages
git clone -b feat/6 https://github.com/mus264/264-tools.git

Previously, playback always started from x=0, now it starts from the
last set scrub position (and resets scrub position to x=0 when it is
stopped/done playing). In addition, scrubbing during playback now moves
the playhead. This allows a user to scrub to x=n during playback and
playback will continue from n.
`patcherargs @loop 0` would trigger after a loadbang in a parent patch
causing a module sent “loop 1” on load to still have looping disabled
Max 7 reduces the number of color attributes available for function
objects. Previously, the function object used to display the moving
cursor had all colors set to transparent with pointcolor set to white.
In Max 7, linecolor alone replaces linecolor, pointcolor, and 
sustaincolor, so for the cursor to be visible, linecolor must also be
set to white. (Because the cursor is a single point the line itself is
never drawn in any case.)
@delucis
Copy link
Member Author

delucis commented Feb 27, 2019

@jsbean Any chance you’ll have time to look at this and we can get it merged?

@delucis
Copy link
Member Author

delucis commented Mar 11, 2019

@jsbean 👍👎?

@jsbean
Copy link

jsbean commented Mar 13, 2019

(Sorry for the delay). This is great! Works beautifully on my end.

One question re: random: would it make sense if the random points are laid out from 0 to 127 on the x axis? That is, it seems like the x value is randomized as well, but maybe it would be more immediately usable if the first x value starts right at 0.

Perhaps (after this is merged) there could be a progressively disclosed option to indicate the range of randomness, with a default of being scaled along the x axis.

@delucis
Copy link
Member Author

delucis commented Mar 13, 2019

@jsbean So the default would be to divide the x-axis into equal intervals? Or just that points 0 and n should clip to the extremes? I guess my reasoning was that this generates less predictable curves, but maybe more regular spacing in time could be useful as you suggest.

@jsbean
Copy link

jsbean commented Mar 13, 2019

I wasn’t thinking splitting into equal intervals, but rather that point 1 would be at x=0, and point n would be at x=127, with the random distribution of x values of the remaining points scaled accordingly.

delucis added 4 commits March 15, 2019 15:53
The line in the function editor (and its points) will be coloured yellow 
to match the colour of the “move mode” button in its active state to 
help indicate the editor’s state
To help users know they are in move mode, this shows a custom “hand” 
cursor when over the function editor. While the mosue is pressed, the 
hand closes as if it is grabbing the function.
@delucis delucis merged commit 881de9b into master Mar 24, 2019
@delucis delucis deleted the feat/6 branch March 24, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants