Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: When config set-reduce-vol-when-voice is set to True, set max volume is not respected #1143

Open
1 of 3 tasks
sypion opened this issue Nov 19, 2024 · 1 comment · May be fixed by #1147
Open
1 of 3 tasks

[bug]: When config set-reduce-vol-when-voice is set to True, set max volume is not respected #1143

sypion opened this issue Nov 19, 2024 · 1 comment · May be fixed by #1147
Labels
support

Comments

@sypion
Copy link

sypion commented Nov 19, 2024 •
edited
Loading

What's happening?
When /config set-reduce-vol-when-voice is used and set to True, if someone were to speak, the bot functions correctly by temporarily lowering the volume to an amount specified, however, the volume returns to 100% instead of the currently set volume, for example, 20%, when everyone in the voice channel is no longer speaking.

Runtime
I'm running Muse:

  • Directly from the cloned repository
  • Inside a Docker container
  • Something else (please elaborate)

Versions

  • Muse: 2.10.0
  • Docker (if applicable): 27.3.1
  • OS: Debian GNU/Linux 12 (bookworm)
@sypion sypion added the support label Nov 19, 2024
Codixer added a commit to Codixer/muse that referenced this issue Nov 24, 2024
@Codixer
Fix volume issue when reducing volume during voice
3a7b0f6 
Fixes museofficial#1143

Add functionality to return to the previously set volume after reducing volume when someone speaks.

* Add a new variable `previousVolume` to store the previously set volume.
* Update the `setVolume` method to update the `previousVolume` variable whenever the volume is set.
* Update the `suppressVoiceWhenPeopleAreSpeaking` method to set the volume to `previousVolume` instead of `defaultVolume`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/museofficial/muse/issues/1143?shareId=XXXX-XXXX-XXXX-XXXX).
@Codixer Codixer linked a pull request Nov 24, 2024 that will close this issue
Open
@Codixer
Copy link
Contributor

Codixer commented Nov 24, 2024

Mind trying with ghcr.io/museofficial/muse:pr-1146?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix volume issue when reducing volume during voice Codixer/muse
2 participants
@sypion @Codixer