Fix volume issue when reducing volume during voice #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes museofficial#1143 Add functionality to return to the previously set volume after reducing volume when someone speaks. * Add a new variable `previousVolume` to store the previously set volume. * Update the `setVolume` method to update the `previousVolume` variable whenever the volume is set. * Update the `suppressVoiceWhenPeopleAreSpeaking` method to set the volume to `previousVolume` instead of `defaultVolume`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/museofficial/muse/issues/1143?shareId=XXXX-XXXX-XXXX-XXXX).
📦 🤖 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1143
Add functionality to return to the previously set volume after reducing volume when someone speaks.
previousVolumeto store the previously set volume.setVolumemethod to update thepreviousVolumevariable whenever the volume is set.suppressVoiceWhenPeopleAreSpeakingmethod to set the volume topreviousVolumeinstead ofdefaultVolume.For more details, open the Copilot Workspace session.