feat: automatically turn volume down when people talks #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xytxxx
force-pushed
the
auto-turn-voice-down-when-people-speaks
branch
from
9bd3b03 to
aae9825
Compare
📦 🤖 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
|
@Hazzajenko Would you be able to test and confirm this feature still works? |
Sure I'll have a look after work today |
Updated env variables with discord commands.
…and to set the target volume.
Removed obsolete TURN_DOWN_VOLUME_WHEN_PEOPLE_SPEAK and TURN_DOWN_VOLUME_WHEN_PEOPLE_SPEAK_TARGET environment variables and corresponding class properties as we will use the discord commands instead.
Changed the section to mention the discord commands rather than the env variables.
…eakTarget` fields to the `Setting` model in Prisma
|
I've updated the volume reduction feature to align with the standard approach of addons in muse:
|
Codixer
changed the base branch from
master
to
feature/lower-volume-when-talking
|
LGTM |
Codixer
merged commit d4e1124
into
museofficial:feature/lower-volume-when-talking
4 checks passed
|
🚀 Released in Release v2.10.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature that automatically lowers the music volume when users in the voice channel are speaking. The feature can be turned on/off through environment variables (default is off), and the target volume of when people are talking is also configurable (default is 70%).
Tested in personal Discord and found 70% volume leads to subtly better experience.