Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made error message format consistent #591

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Made error message format consistent #591

merged 4 commits into from
Mar 23, 2022

Conversation

therithwikrayani
Copy link
Contributor

@therithwikrayani therithwikrayani commented Mar 19, 2022 •
edited
Loading

Closes #590

Made error message format consistent

  • I updated the changelog

@github-actions
Copy link

github-actions bot commented Mar 19, 2022 •
edited
Loading

📦 A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-591 or codetheweb/muse:92cfa3e9ee4eed1cd40399324af1ee3b31f3a83e.

Images are available for x86_64 and ARM64.

Latest commit: 92cfa3e

codetheweb
codetheweb requested changes Mar 19, 2022
View reviewed changes
Copy link
Collaborator

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep the ope prefix. :)

Are there any other spots to your knowledge that would have to be changed too?

src/utils/error-msg.ts Outdated Show resolved Hide resolved
src/utils/error-msg.ts Outdated Show resolved Hide resolved
@therithwikrayani
Copy link
Contributor Author

Very well, done as suggested

@therithwikrayani
Copy link
Contributor Author

No errors are thrown without using error-msg.ts, so shouldn't have to make changes anywhere else.

@codetheweb
Copy link
Collaborator

Thanks!

@codetheweb codetheweb merged commit cf49053 into museofficial:master Mar 23, 2022
@github-actions
Copy link

🚀 Released in Release v1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codetheweb codetheweb codetheweb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent error message formatting
2 participants
@therithwikrayani @codetheweb