Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breve rests outside the staff should have ledger lines. #25230

Open
2 tasks done
rpatters1 opened this issue Oct 19, 2024 · 0 comments · May be fixed by #25248
Open
2 tasks done

Breve rests outside the staff should have ledger lines. #25230

rpatters1 opened this issue Oct 19, 2024 · 0 comments · May be fixed by #25248
Labels
feature request Used to suggest improvements or new capabilities

Comments

@rpatters1
Copy link
Contributor

rpatters1 commented Oct 19, 2024

Your idea

Breve rests outside the staff should display with ledger lines. Since Gould does not mention breve rests with ledger lines, I suppose it must be a Style option. The Rest panel is getting a bit crowded, but that seems like the most logical place.

Problem to be solved

While Gould and Ross are silent about breve rests with ledger lines, examples are easy enough to find in the literature. The following is from the Brahms Requiem (p. 161 of the Dover score).

Screen Shot 2024-10-19 at 12 01 33 PM

And another (p. 166) showing both top and bottom ledger lines.

Screen Shot 2024-10-19 at 12 20 32 PM

Prior art

No response

Additional context

Since there is already a rest symbol for breve-with-ledger-lines, this seems like a trivial change to Rest::getSymbol as follows:

    case DurationType::V_BREVE:
        return (line <= 0 || line >= lines) ? SymId::restDoubleWholeLegerLine : SymId::restDoubleWhole;
    case DurationType::V_MEASURE:
        if (ticks() >= Fraction(2, 1)) {
            return getSymbol(DurationType::V_BREVE, line, lines);
        }

There would be a little more work to implement a style setting if that were deemed necessary.

Checklist

  • This request follows the guidelines for reporting issues
  • I have verified that this feature request has not been logged before, by searching the issue tracker for similar requests
@muse-bot muse-bot added the feature request Used to suggest improvements or new capabilities label Oct 19, 2024
@rpatters1 rpatters1 linked a pull request Oct 20, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Used to suggest improvements or new capabilities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants