Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ledger line option for breve rests #25248

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rpatters1
Copy link
Contributor

Resolves: #25230

This PR adds an option to the Styles->Rest page to show ledger lines on breve rests as shown:

Screen Shot 2024-10-20 at 5 30 23 PM

When the option is checked, breve rests have ledger lines (top and bottom) when they sit on the top staff or higher or hang from the bottom staff or lower. This matches the practice of Breitkopf & Härtel as illustrated in the Brahms Requiem score.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@rpatters1 rpatters1 force-pushed the breve-rests-with-ledger-lines branch from 9f60227 to 6d87e1f Compare October 22, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breve rests outside the staff should have ledger lines.
1 participant