Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4 Issue] Closing one of multiple projects leaves windows open (potential usability trap) #9966

Closed
bkunda opened this issue Dec 3, 2021 · 2 comments · Fixed by #10067 or #17676
Closed

[MU4 Issue] Closing one of multiple projects leaves windows open (potential usability trap) #9966

bkunda opened this issue Dec 3, 2021 · 2 comments · Fixed by #10067 or #17676
Assignees
@Eism
Labels
P2 Priority: Medium
Milestone
Sprint 51

Comments

@bkunda
Copy link

bkunda commented Dec 3, 2021

Describe the bug
Closing one of multiple open projects causes the score to close, but the project window remains open and the user is left seeing the workspace, wallpaper, and app icon in the system tray.

A potential issue with this is that the user could be forgiven for thinking their project is still open:

  • They still see the MuseScore app icon in the system tray. Clicking on it brings forward an "empty" screen.
  • They may attempt to quit MuseScore to solve this, inadvertently closing all other open projects.

Screenshot 2021-12-04 at 12 09 29 am

Expected behavior
My recommendation would be that, where more than one project is open, closing a project closes the entire window and removes the app icon from the system tray. Only where only one project is open should a close command keep the window open (so the user can open another score).

This behaviour would be triggered by:

  • File > Close
  • Cmd/Ctrl+W
  • Closing the window with the "X" icon in the title bar

Desktop (please complete the following information):

  • OS: [e.g. iOS]
@bkunda bkunda added the P2 Priority: Medium label Dec 3, 2021
@bkunda bkunda changed the title [MU4 Issue] Closing one of multiple projects creates leaves windows open (potential usability trap) [MU4 Issue] Closing one of multiple projects leaves windows open (potential usability trap) Dec 3, 2021
@vpereverzev vpereverzev added this to the Sprint 50 milestone Dec 6, 2021
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Dec 12, 2021
@RomanPudashkin
fix musescore#9966: added closing of the app window after closing the…
7736e49 
… current project if there are other instances of the app
@RomanPudashkin RomanPudashkin mentioned this issue Dec 13, 2021
Merged
@vpereverzev vpereverzev modified the milestones: Sprint 50, Sprint 51 Dec 13, 2021
RomanPudashkin added a commit that referenced this issue Dec 13, 2021
@RomanPudashkin
Merge pull request #10067 from RomanPudashkin/close_empty_instances_fix
568f6e5 
[MU4] Fix #9966: Closing one of multiple projects leaves windows open
@Eism Eism mentioned this issue Oct 15, 2022
Closed
@DmitryArefiev DmitryArefiev assigned Eism and unassigned RomanPudashkin May 22, 2023
@DmitryArefiev
Copy link
Contributor

Happens again in 4.0.2, 4.1

bandicam.2023-05-22.12-29-13-896.mp4

@DmitryArefiev DmitryArefiev reopened this May 22, 2023
Eism added a commit to Eism/MuseScore that referenced this issue May 22, 2023
@Eism
fixed musescore#9966: Call quit asynchronously for correct quitting
b193544 
A cyclic dependency has occurred
ActionController::quit re-calls the ProjectActionsController::closeOpenedProject method which has not yet completed
@Eism Eism mentioned this issue May 22, 2023
Merged
@RomanPudashkin RomanPudashkin moved this from To do to In Progress in MuseScore 4.1 May 22, 2023
Eism added a commit to Eism/MuseScore that referenced this issue May 24, 2023
@Eism
fixed musescore#9966: Call quit asynchronously for correct quitting
7580349 
A cyclic dependency has occurred
ActionController::quit re-calls the ProjectActionsController::closeOpenedProject method which has not yet completed
@DmitryArefiev
Copy link
Contributor

Fixed in #17676

@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore 4.1 May 24, 2023
DmitryArefiev added a commit that referenced this issue May 24, 2023
@DmitryArefiev
Merge pull request #17676 from Eism/mi_closing_app_fix
c0e876d 
fixed #9966: Closing one of multiple projects leaves windows open
willkell pushed a commit to willkell/MuseScore that referenced this issue May 26, 2023
@Eism @willkell
fixed musescore#9966: Call quit asynchronously for correct quitting
ab6139a 
A cyclic dependency has occurred
ActionController::quit re-calls the ProjectActionsController::closeOpenedProject method which has not yet completed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eism Eism

Labels
P2 Priority: Medium
Projects
No open projects
MuseScore 4.1
Status: Done
Milestone
Sprint 51
6 participants
@igorkorsukov @Eism @vpereverzev @RomanPudashkin @bkunda @DmitryArefiev