Collected code cleanups #23159
Merged
Collected code cleanups #23159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unnecessary recursive calls. https://github.com/musescore/MuseScore/pull/19247/files#r1375433082
These options were added in musescore#19795 and musescore#22243
igorkorsukov
approved these changes
Jun 10, 2024
wizofaus
reviewed
Jun 11, 2024
| { | ||
| if (!m_inited) { |
There was a problem hiding this comment.
this change appears to have broken the Format|Style dialog? For me at least, load() is never getting called. I believe it's in the case where you have checkboxes in QML with their checked property initialise as, e.g.:
checked: modelData.value === restsPageModel.multiVoiceRestTwoSpaceOffset.value
(there are multiple such examples). Looks to me like calling load() from "onCompleted" is too late. Various ways it could be fixed but I'll leave it to you, I have my own kludgy fix (similar to old code that just calls load() as required, requiring const_cast) that allows me to do what I need to!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.