Fix system text line sync issues #26279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
fixSystemTextLineSyncIssues
branch
from
ba9ae6d to
9a01ad8
Compare
oktophonie
approved these changes
Feb 3, 2025
mike-spa
force-pushed
the
fixSystemTextLineSyncIssues
branch
from
9a01ad8 to
209cafe
Compare
miiizen
approved these changes
Feb 5, 2025
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 5, 2025
Backport of musescore#26279, commit 2
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 5, 2025
Backport of musescore#26279, commit 2
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 6, 2025
Backport of musescore#26279, commit 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #25356
This is a twofold issue.
First, I think we should always force items linked within the same score (as opposed to items linked in other parts) to stay synced. That's partially because I think it's what the user wants most of the time. But most importantly because items linked within the main score don't have these toggles available at the moment, which means if we let them unsync there is no way for the user to then re-sync them.
In future, we could implement something for the main score where the "top" system object rules the other clones and clones can be synced or unsynced etc. Or maybe not. But for now anyway, I think the only option is to force them to stay synced.
I think some of the properties pointed out in the issue should't be allowed to desync at all (meaning not even between score and parts). These are: "Show line", "Line style" and "Start/end hook type".