Skip to content

Fix #17599: Gradual tempo changes skipped by Alt+Left and Alt+Right #27465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guibentoU
Copy link

Added conditions in some functions in spanner.cpp and segment.cpp so that the gradual tempo change would be returned, when it was the next or previous element,
before there was no case for this.

Resolves: #17599

When navigating with alt+left or alt+right the gradual tempo change was not accessible through any other element, also when starting from a gradual tempo change the alt+right would work as intended but the alt+left would not, it would instead go to the first element the title. I believe I fixed the problem, but I think that the solution is too specific in the spanner.cpp and segment.cpp.

  • [ x] I signed the CLA
  • [ x] The title of the PR describes the problem it addresses
  • [ x] Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • [ x] The code in the PR follows the coding rules
  • [ x] There are no unnecessary changes
  • [ x]The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

…t+Right

Added conditions in some functions in spanner.cpp and segment.cpp
so that the gradual tempo change would be returned,
when it was the next or previous element,
before there was no case for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] Gradual tempo changes skipped by Alt+Left and Alt+Right
1 participant