Fix "select similar in range" for spanners #27577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays, not Spanners, but SpannerSegments are included in `m_selection.elements()`.
mathesoncalum
approved these changes
Apr 7, 2025
Comment on lines
3886
to
+3892
| if (p->measure) { | ||
| auto eMeasure = e->findMeasure(); | ||
| if (!eMeasure && e->isSpannerSegment()) { | ||
| if (auto ss = toSpannerSegment(e)) { | ||
| if (auto s = ss->spanner()) { | ||
| if (auto se = s->startElement()) { | ||
| if (auto mse = se->findMeasure()) { | ||
| eMeasure = mse; | ||
| } | ||
| if (auto s = toSpannerSegment(e)->spanner()) { | ||
| if (auto se = s->startElement()) { | ||
| if (auto mse = se->findMeasure()) { | ||
| eMeasure = mse; |
There was a problem hiding this comment.
While we're at it, we ideally reserve auto for iterators and other complex types right? I think it's unnecessary here.
Also as a bonus I'd love to flatten this nesting a little - perhaps by checking !p-measure and returning early? (maybe that ends up even uglier, its up to you).
|
Tested #27548 on Win10, Mac13.7.2, LinuxUbuntu24.04.2 LTS - FIXED
Yes, they were broken too. Now work fine |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, not Spanners, but SpannerSegments are included in
m_selection.elements().Resolves: #27548
QA note: seems the issue applied to other spanner elements as well (hairpins, text lines, ...); would be good to test those too.