Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable mypy for new modules by default #1849

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

Jc2k
Copy link
Contributor

@Jc2k Jc2k commented Jan 9, 2025

All new modules must pass mypy.

Existing modules should be removed from the exclude list as they are fixed.

There was conflicting config in mypy.ini and pyproject.toml, so this merges them to be stricter and to only use pyproject.toml.

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, appreciate your efforts getting the code in the right shape for testing and linting!

@marcelveldt marcelveldt merged commit 3de2757 into dev Jan 9, 2025
6 checks passed
@marcelveldt marcelveldt deleted the mypy-default-enabled branch January 9, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants