Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Audiobookshelf: Less API calls + more debugging messages #1906

Merged
merged 18 commits into from
Jan 23, 2025

Conversation

fmunkes
Copy link
Contributor

@fmunkes fmunkes commented Jan 23, 2025

Improvements

API calls [commits on Jan 21st/ 22nd]

API calls are reduced significantly by

  • making use of the minimized versions of podcast/ audiobooks provided to us anyways when syncing library items. Just a single api call per library, instead of several per item.
  • storing the libray items ids in the client instead of acquiring them in browse function

Schema [commits today]

  • If schema parsing fails, this is logged as an error now.
  • I commented as many attributes as possible in abs_schema.py, which we don't use currently. No blaming intended, but I think the API docs of abs are not completely up to date with development, thus my typing is apparently not always appropriate.
    Nonetheless, I'll see how can do snapshot testing this weekend.

Other

  • There is a 1s delay before returning session details. I sometimes had the issue of mass being faster in acquiring than abs in creating the stream
  • Discord: There is an advanced option in the setup screen, which won't sync podcasts with no episode.

@marcelveldt marcelveldt merged commit fb589de into music-assistant:dev Jan 23, 2025
3 checks passed
@fmunkes fmunkes deleted the abs_reduce_api_calls branch January 24, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants