Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class mismatch #832

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix class mismatch #832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions music_assistant/server/providers/tidal/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ async def _parse_artist(self, artist_obj: TidalArtist, full_details: bool = Fals
"""Parse tidal artist object to generic layout."""
artist_id = artist_obj.id
artist = Artist(
item_id=artist_id,
item_id=str(artist_id),
provider=self.instance_id,
name=artist_obj.name,
provider_mappings={
Expand Down Expand Up @@ -509,13 +509,13 @@ async def _parse_album(self, album_obj: TidalAlbum, full_details: bool = False)
version = album_obj.version if album_obj.version is not None else None
album_id = album_obj.id
album = Album(
item_id=album_id,
item_id=str(album_id),
provider=self.instance_id,
name=name,
version=version,
provider_mappings={
ProviderMapping(
item_id=album_id,
item_id=str(album_id),
provider_domain=self.domain,
provider_instance=self.instance_id,
audio_format=AudioFormat(
Expand Down Expand Up @@ -575,14 +575,14 @@ async def _parse_track(
else:
track_class = Track
track = track_class(
item_id=track_id,
item_id=str(track_id),
provider=self.instance_id,
name=track_obj.name,
version=version,
duration=track_obj.duration,
provider_mappings={
ProviderMapping(
item_id=track_id,
item_id=str(track_id),
provider_domain=self.domain,
provider_instance=self.instance_id,
audio_format=AudioFormat(
Expand All @@ -597,9 +597,10 @@ async def _parse_track(
},
**extra_init_kwargs,
)
# Here we use an ItemMapping as Tidal return minimal data when getting an Album from a Track
track.album = self.get_item_mapping(
media_type=MediaType.ALBUM,
key=track_obj.album.id,
key=str(track_obj.album.id),
name=track_obj.album.name,
)
track.artists = []
Expand Down Expand Up @@ -633,13 +634,13 @@ async def _parse_playlist(
creator_id = playlist_obj.creator.id if playlist_obj.creator else None
creator_name = playlist_obj.creator.name if playlist_obj.creator else "Tidal"
playlist = Playlist(
item_id=playlist_id,
item_id=str(playlist_id),
provider=self.instance_id,
name=playlist_obj.name,
owner=creator_name,
provider_mappings={
ProviderMapping(
item_id=playlist_id,
item_id=str(playlist_id),
provider_domain=self.domain,
provider_instance=self.instance_id,
url=f"http://www.tidal.com/playlists/{playlist_id}",
Expand Down