Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add some wlw flags 😊 #17

Merged
merged 2 commits into from
Jun 3, 2024
Merged

feat: Add some wlw flags 😊 #17

merged 2 commits into from
Jun 3, 2024

Conversation

c42f
Copy link
Contributor

@c42f c42f commented Jun 3, 2024

Thanks for this package, love it!

Here's some sapphic color schemes! As described in the code comments, I've got the color codes from these from https://lgbtqia.fandom.com/wiki/Sapphic and https://lgbtqia.fandom.com/wiki/Lesbian.

Demo:

image

(don't worry about the convert junk - that's only required until JuliaGraphics/ColorTypes.jl#293 propagates)

@musoke
Copy link
Owner

musoke commented Jun 3, 2024

Thanks! Could you add them to the docstring for PROUD_PALETTES too?

@c42f
Copy link
Contributor Author

c42f commented Jun 3, 2024

Done!

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3dfb79b). Learn more about missing BASE report.

Current head 7c54184 differs from pull request most recent head 5126653

Please upload reports for the commit 5126653 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #17   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         2           
  Lines           ?         5           
  Branches        ?         0           
========================================
  Hits            ?         5           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@musoke musoke merged commit 4c6352c into musoke:main Jun 3, 2024
11 checks passed
@musoke
Copy link
Owner

musoke commented Jun 3, 2024

Thank you @c42f !

Do you think that something similar to your demo would work for displaying the palettes in the docs?

@c42f
Copy link
Contributor Author

c42f commented Jun 4, 2024

I don't know. The issue with the docs is that they're markdown, but markdown doesn't have a way of talking about color. The above demo is done with ANSI color codes; those are only relevant in the terminal so should only be added when rendering the markdown in a text terminal.

Hmm. Possibly "the right thing" would be to construct the docstring as a Base.AnnotatedString so that it can carry color information but unfortunately that doesn't seem to survive the markdown parser at the moment:

image

There's some progress in the direction of making Markdown stdlib use AnnotatedString for highlighting. So perhaps this will work one day. See JuliaLang/julia#51928

@tecosaur any thoughts?

@c42f c42f deleted the caf/wlw branch June 4, 2024 02:09
@tecosaur
Copy link

tecosaur commented Jun 4, 2024

I'm not sure how annotations in a Markdown.MD object could survive, however one fun extra that came with the use of StyledStrings in Markdown is a styled code block:

image

Perhaps that could help? 🙂

@musoke
Copy link
Owner

musoke commented Jun 4, 2024

Yeah, this seems tricky. Possibly intentionally so, since some terminals can't render colours correctly anyway.

@c42f
Copy link
Contributor Author

c42f commented Jul 17, 2024

@tecosaur that is amazing, thank you. Exactly what I wanted to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants