-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add some wlw flags 😊 #17
Conversation
Thanks! Could you add them to the docstring for |
Done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 2
Lines ? 5
Branches ? 0
========================================
Hits ? 5
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Thank you @c42f ! Do you think that something similar to your demo would work for displaying the palettes in the docs? |
I don't know. The issue with the docs is that they're markdown, but markdown doesn't have a way of talking about color. The above demo is done with ANSI color codes; those are only relevant in the terminal so should only be added when rendering the markdown in a text terminal. Hmm. Possibly "the right thing" would be to construct the docstring as a There's some progress in the direction of making Markdown stdlib use AnnotatedString for highlighting. So perhaps this will work one day. See JuliaLang/julia#51928 @tecosaur any thoughts? |
Yeah, this seems tricky. Possibly intentionally so, since some terminals can't render colours correctly anyway. |
@tecosaur that is amazing, thank you. Exactly what I wanted to work! |
Thanks for this package, love it!
Here's some sapphic color schemes! As described in the code comments, I've got the color codes from these from https://lgbtqia.fandom.com/wiki/Sapphic and https://lgbtqia.fandom.com/wiki/Lesbian.
Demo:
(don't worry about the
convert
junk - that's only required until JuliaGraphics/ColorTypes.jl#293 propagates)