[WIP] Flexbuffers #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new storage container _InternalByteBuffer which will be holding the data that will be created within the swift lib, however reading data will be redirected to ByteBuffer, which should be able to handle all types of data that swift provide without the need to copy the data itself. This is due to holding a reference to the data. Removed unowned from the initializer Replaces assumingMemoryBinding with bindMemory which is safer Adds function that provides access to a UnsafeBufferPointer for scalars and NativeStructs within swift Updates docs Suppress compilation warnings by replacing var with let
Using overflow operators within swift to improve performance Adds tests for GRPC message creation from a retained _InternalByteBuffer
github-actions
bot
added
c++
codegen
documentation
mustiikhalil
force-pushed
the
flexbuffers
branch
3 times, most recently
from
bf7c2ed to
1dd2f1e
Compare
This is the offical port for FlexBuffers within swift, and it introcudes a Common Module where code is shared between flatbuffers and flexbuffers. Writing most supported values like maps, vectors, nil and scalars into a flexbuffer buffer. And includes tests to verify that its similar to cpp
mustiikhalil
force-pushed
the
flexbuffers
branch
from
1dd2f1e to
db7f3a4
Compare
Successfully read count for map
mustiikhalil
force-pushed
the
flexbuffers
branch
from
c6cd61f to
86fbaaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a PR!
Please delete this standard text once you've created your own description.
If you make changes to any of the code generators (
src/idl_gen*) be sure tobuild your project, as it will generate code based on the changes. If necessary
the code generation script can be directly run (
scripts/generate_code.py),requires Python3. This allows us to better see the effect of the PR.
If your PR includes C++ code, please adhere to the
Google C++ Style Guide,
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
so only some C++11 support is available.
For any C++ changes, please make sure to run
sh scripts/clang-format-git.shInclude other details as appropriate.
Thanks!