This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
[INTERNAL] Update retry mechanics #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 12, 2022 17:03
Refactors the internals of `waitForDeployCreation` to use p-retry. The p-retry library: * Has a more straightforward API than `setInterval`/`setTimer` * Uses exponential backoff for the retry semantics * Allows for further refinement of the operations * Makes the first request immediately which can shorten run times when the resource is already available. Refer to: * https://github.com/sindresorhus/p-retry * https://github.com/tim-kos/node-retry
Refactors the internals of `waitForReadiness` to use p-retry. The p-retry library: * Has a more straightforward API than `setInterval`/`setTimer` * Uses exponential backoff for the retry semantics * Allows for further refinement of the operations * Makes the first request immediately which can shorten run times when the resource is already available. Refer to: * https://github.com/sindresorhus/p-retry * https://github.com/tim-kos/node-retry
Refactors the internals of `waitForUrl` to use p-retry. The p-retry library: * Has a more straightforward API than `setInterval`/`setTimer` * Uses exponential backoff for the retry semantics * Allows for further refinement of the operations * Makes the first request immediately which can shorten run times when the resource is already available. The tests have been updated to more accurately reflect how Axios behaves in certain circumstances - errors for non-200 response. Refer to: * https://github.com/sindresorhus/p-retry * https://github.com/tim-kos/node-retry
Now that the wait* functions are using `p-retry` the short timeouts are not needed in the test workflow because the initial request is performed immediately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO