Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With stretch drawers enabled, a nil drawer will also be stretched #1

Closed
danmurrelljr opened this issue May 8, 2013 · 4 comments
Closed

With stretch drawers enabled, a nil drawer will also be stretched #1

danmurrelljr opened this issue May 8, 2013 · 4 comments
Assignees
@larsacus
Labels
bug
Milestone
0.0.2

Comments

@danmurrelljr
Copy link
Contributor

While testing with drawer stretching enabled, on an app that only uses a left drawer (right drawer is nil), the right side is also stretchable anyway and pulls some of the center view over.

You can verify this in the KitchenSink example by initializing the drawerController with a nil right drawer.
@ghost ghost assigned larsacus May 8, 2013
@kcharwood
Copy link
Contributor

Yup I see the bug. That feature went in late so we missed the nil side drawer case. @larsacus will hit it tonight, and we'll update to 1.0.1 within the next 24 hours.

@kcharwood
Copy link
Contributor

Btw if you set shouldStretchDrawer to NO for the time being, that will allow you to work around that.

@kcharwood kcharwood mentioned this issue May 8, 2013
Closed
larsacus added a commit that referenced this issue May 9, 2013
@larsacus
Fixed case where drawer side controller is nil. Fixes #1
d5dc89d
kcharwood added a commit that referenced this issue May 9, 2013
@kcharwood
Potential fix for #1
f7599f2
@kcharwood kcharwood mentioned this issue May 9, 2013
Merged
larsacus added a commit that referenced this issue May 9, 2013
@larsacus
Merge pull request #5 from mutualmobile/nil_drawer_fix2
fd7ed7a 
Fixes issue #1: nil drawer panning issue.
@larsacus
Copy link
Contributor

larsacus commented May 9, 2013

Fixed in PR #5.

@larsacus larsacus closed this as completed May 9, 2013
@kcharwood
Copy link
Contributor

I said 1.0.1 above, but I meant 0.0.2. I think this fix is critical enough to roll out 0.0.2 very soon. I'll begin prepping it now.

@kcharwood kcharwood reopened this May 9, 2013
@djibouti33 djibouti33 mentioned this issue Aug 28, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsacus larsacus

Labels
bug
Projects
None yet
Milestone
0.0.2
Development

No branches or pull requests
3 participants
@danmurrelljr @kcharwood @larsacus