-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Subclassing Procedures/Documentation #36
Comments
I don't want to throw water on this just yet, but we made need to rethink it... The purpose of UIGestureRecognizerSubclass.h is:
If we follow that example, then methods included in that header should be methods that must be overridden by a subclass. In our case, for methods that can be overridden in a subclass, maybe we just expose them in the normal header file like UIViewController does... |
That's kind of what I was going for here were methods that were not at all relevant to the normal operation of MMDrawerController, but may be relevant to developers who would like to extend MMDrawerController by augmenting or replace existing implementations of some internal methods in MMDrawerController. The example that UIGestureRecognizerSubclass.h uses is not implicit, but an explicit, fully documented action in the header that states that all of the methods declared in that header must be overridden. This keeps the header file clean for developers, while still providing additional functionality to those who want it in the subclass header. |
Closing this and moving discussion to #37 |
I've been seeing more and more issues and requests for features that may not be appropriate for
MMDrawerController
core, but are more suited toward specific applications. This would be best solved by subclassingMMDrawerController
, but we currently don't have a formal set of rules and such for developers to subclassMMDrawerController
.A list of things off the top of my head we need for easy developer subclassing:
__attribute((objc_requires_super))
MMDrawerController+Subclass.h
, much likeUIGestureRecognizerSubclass.h
does). This would also contain more documentation on these methods and what they do.The text was updated successfully, but these errors were encountered: