Added Subclass Documentation/Headers #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather start small here, and move forward with people's specific needs, so I removed a few things that seemed overkill right now. If we see people with specific needs that could use access to specific methods, we can expand it in the future. |
This was referenced Aug 13, 2013
Conflicts: MMDrawerController/MMDrawerController.h
kcharwood
added a commit
that referenced
this pull request
Aug 16, 2013
Added Subclass Documentation/Headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some basic support for making it easier for devs to subclass MMDrawerController (#36) and handle some of the more specific requests that I've been seeing.
I'd like to wait until at least #20 is merged before merging this.
This would make #26 & #31 pretty easy for a developer.
This is a start to exposing some of the more "private" methods of MMDrawerController to a subclass. If anyone feels any of the exposed methods should be removed or some should be added feel free to chime in.