Additional parameters for drawer paddings #26
Conversation
let us make the drawer a little bit bigger than the `maximumLeftDrawerWidth` to cover round corners of a central controller for instance
|
Thanks for pull request the @dulaccc! I've been chewing on this feature since we before we open sourced it, and haven't quite landed on how I would like to handle it. I would really like to avoid adding more properties if possible... I've been brainstorming if there is way to handle this automatically for the user (i.e. inspect the center view controller to find out if there are rounded corners, and automatically adjust based on that, but I haven't had time to research it). Also, if you look at the Facebook app, they don't handle this correctly (you'll see a tiny black spec under the rounded corner). Let me think about this some more. 🍻 |
|
So glad to hear to that you've been thinking about it too :) Just to saying, thanks for your amazing work, that's clearly the best implementation of a "Facebook/Path 2.0" panel-like interface I've found, and I tested a lot of them! I will check if I can make the PR without any extra parameters, I agree it'd be a lot better. |
|
Dare I say this might be best handled as a subclass of |
|
I'm going to close this for now. It's probably best handled in a subclass, which we need to provide better documented support for. If more people clamor for this, we'll consider it for a first class citizen feature in the library, but so far 3 months in there has not been much demand for it. |
|
Fair enough. I'll use now the subclass solution too. |
Let us make the drawer controllers a little bit bigger than the
maximumLeftDrawerWidthto cover round corners of a central controller for instance with the background of the drawer.