Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pan view on certain views in the center view? Is it possible? #54

Closed
mmarszal opened this issue Jul 3, 2013 · 3 comments
Closed

Comments

@mmarszal
Copy link

mmarszal commented Jul 3, 2013

First of all, I just wanted to say that this controller is by far, the best implementation i've seen for the drawer paradigm. It's absolutely fantastic. Switching to this from other implementations has not only been pleasant, but it actually has made my code much cleaner.

The only thing I need in this controller is to be able to completely disable the pan gesture for select views on my center view.
What I have right now for my center view is

[Some top layer]
[a uiwebview]
[an uitextview for input]

I only want the pan gesture to available on the uiwebview (and navbar if possible), as the top layer has gesture recognizer. THe input view itself also doesn't need the pan gesture too. Is this currently possible to do with the current implementation of mmdrawercontroller? If so, could you explain how? If not, what would be the easiest (or most ideal) way to subclass this controller to add such a feature? I have no problem forking this and figuring it out myself, but some guidance would be nice to make it more proper. I'm thinking it would be easier to have a list of views to exclude the pan gesture.

Thanks for your time

@kcharwood
Copy link
Contributor

Hey @mmarszal,

Thanks for the issue. I think #25 may also be useful for you. Take a look at the pull request, and let me know if that interests you. Along with #55, it looks like this would be an important feature, so I'd like to get solution that solves all of your use cases.

@mmarszal
Copy link
Author

Hi kcharwood,

I just looked over the code in issue 25, and that just might do the trick for me!
I like the idea of having a block containing the code to control the custom gesture. Seems like quite a clean solution.

@kcharwood
Copy link
Contributor

I'll close this issue and direct conversation to that pull request.

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants