-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panning not working to close center view? #55
Comments
Another issue/feature request is this: when rotation is occurring, MMDrawerController doesn't ask any of the child view controllers whether rotation should happen, or supported rotation modes, or anything. I know this can be easily changed or subclassed, but it bugged me since the default view controllers - like the navigation controller and tab controller - ask sub view controllers if and how rotation should occur. |
Hey @matt-curtis, For the initial question above, take a look at #25 and let me know if the pull request there would fit your need as well. I think it might. I'll bump that to the top of the queue if it looks good to you. As for your second question, that is actually a change that Apple is pushing starting with iOS 6. From the iOS 6 release notes:
MMDrawerController is a container view controller, so it doesnt make sense to consult the children to determine rotation characteristics (especially on iPad). In the future, please try to keep issues limited to one topic, so the conversation doesnt get derailed 🍻 |
Excellent work, guys. Quite appreciated.
My center view controller has two modes: one mode where a view with multiple gesture recognizers is the only view on screen, and another mode where there is an overlay over that view that covers it, and therefore blocks touches to it.
When my center view is in the mode where only the multi-gesture mode, panning works to close it. When it's in the overlay mode, panning does not work, only tapping. I think the key is the delegate method
gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer
, which is attached to the multi-gesture view. That delegate method always returns YES, which is why I think it works, but the overlay one does not (and has no gestures attached).Hopefully I've outlined this well. Are there any suggestions? I've been unable to find other bugs in my code that would cause this to happen.
The text was updated successfully, but these errors were encountered: