Fixed issue 204: center view gets truncated if user holds finger on the screen during the device rotation. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creen during the device rotation. See mutualmobile#204 for reference
…s drawer bar button. Please see mutualmobile#204 for reference
kcharwood
added a commit
that referenced
this pull request
Jun 9, 2014
|
Thanks for sending this up. We actually handled this in the past, but it looks like a regression along the way caused it to get out of whack. I've resolved that in 38e9c2d, and everything should work. Note we don't keep the pan active during that state, but it does UI glitch either. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #204 for reference
Fix description:
If user holds a finger on screen during device rotation and once rotation is complete moves a finger panGestureCallback uses outdated value of self.startingPanRect and adjusts center view improperly. So i'm suggesting to refresh this value just after the rotation.