Do not forward appearance events to central VC when drawer is offscreen

[pronebird]

The idea is to avoid sending appearance events when setting new central controller before drawer put into view hierarchy (or offscreen). This PR fixes issue #261 related to state restoration. Related issue #268.

This patch also adds some minor optimization for side controller setter method to avoid reseting the same view controller. This does make sense with state restoration because at the moment all controllers will be set twice, first time when your code actually instantiates other controllers from storyboard and second time while state restoration decoding.

I tested this patch in my app with and without state restoration and everything works. I haven't tested hot-swap of central controller, but I believe it should work as before.

The good thing, it seems state restoration is smart enough and grabs the last instance of sidebar/central controller instantiated using -[UIStoryboard instantiateViewControllerWithIdentifier:]. If you create controllers manually, then you end up with two different sets of controllers I assume.

If you ask me, I do not encode child VCs for my controllers, because I create them in code anyway. Instead, I save properties that will help me to restore the state of those controllers. From my observations, saving child controller is only makes sense when you use embed segue in storyboard, then you leverage Storyboard to save/restore such controller. But essentially it always creates this controller for you, so you never even decode it, you only encode it.

[ronak2121]

+1

[vanderneut]

I'm surprised to see that this fix has not been merged in yet. The double triggering of viewWillAppear is causing bugs for me as well.

I'll look at the code changes here and try them out on my end and see if that fixes things.

Erik

[pronebird]

Is @kcharwood alive?

[vanderneut]

I'm hoping he's just busy enjoying a nice long Summer vacation ;-)

In my app I ended up coding a workaround so I'm not getting hurt by the double triggering of viewWillAppear. Still hoping that at some point your fix will be pulled in with an MMDrawerController pod update.

Erik

[pronebird]

@vanderneut I hope so too. I use my fork at the moment and planning to switch pod to official pod once it's merged.

[ronak2121]

Same thing here. We've coded workarounds for this for now.

[x2on]

👍 we also use a fork at the moment.

[kcharwood]

@vanderneut I'm alive!!!

Been a very busy summer. Carving out some time this morning to see what I can do here.

[kcharwood]

Sorry for the big delay on this one.

Thanks for the patch!!

🍻

[pronebird]

No worries @kcharwood, cheers 🍺