Fix iOS8 issue where rotation methods are called twice #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying fix from mutualmobile#204
…here they are automatically called from [UIViewController viewWillTransitionToSizeWithTransitionCoordinator:]
|
Thank you for this. This is crucial if you have a master-detail splitview inside the main window. Without this, you'll get the "Unbalanced calls to begin/end appearance transitions" error msg and your viewWillAppear method won't be called. |
|
Do you have an example project pushed up anywhere showing this behavior? |
|
Thanks for the PR! I took it, and cleaned it up in #351 🍻 |
boherna
added a commit
to boherna/MMDrawerController
that referenced
this pull request
Sep 4, 2015
* upstream/master: (21 commits) Fixes mutualmobile#367 Added notes for reference Add missing appearance transition forwarding Fixed changelog Updated changelog Updated changelog updated changelog Fix infinite, recursive init call for subclass Replaced iOS 6 deprecated `-shouldAutorotateToInterfaceOrientation:` method with new one Cleaned up PR mutualmobile#288 Prevent several rotation methods from getting called twice in iOS8, where they are automatically called from [UIViewController viewWillTransitionToSizeWithTransitionCoordinator:] Update MMDrawerController.m Updated documentation Removed pre iOS 7 support Switched id to instancetype Fix for mutualmobile#287 Added iPhone 6/6+ support Cleaned up setter methods Added shadow color property from mutualmobile#294 Updated UI properties from mutualmobile#338 Call removeFromParentViewController after removeFromSuperview in setCenterViewController to avoid EXC_BAD_ACCESS due to nil view value ... Conflicts: MMDrawerController/MMDrawerController.h MMDrawerController/MMDrawerController.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on iOS 8 GM, I noticed that methods like willRotateToInterfaceOrientation:toInterfaceOrientation: were getting called twice on any UIViewControllers that were children of MMDrawerController. This fix should help.