Call removeFromParentViewController after removeFromSuperview in setCent... #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enterViewController to avoid EXC_BAD_ACCESS due to nil view value
|
👍 |
1 similar comment
|
👍 |
|
Sorry for just getting to this. I'll get this reviewed and tested this week! |
kcharwood
added a commit
that referenced
this pull request
Mar 16, 2015
Call removeFromParentViewController after removeFromSuperview in setCent...
|
Thanks! |
|
This causes quite a few issues for a project I'm maintaining. After updating to 0.6.0 from 0.5.7 I start experiencing that my viewControllers are not actually dealloc'ed. If I revert this specific change, then everything works as expected. Any ideas? |
|
same question about viewControllers being actually dealloc'ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...erViewController to avoid EXC_BAD_ACCESS due to nil view value
Resolves an encountered issue with NappDrawer (viezel/NappDrawer#139) where setting the center window would result in an app crash