Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gesture completion block not executed when panning to the left (until the end of screen) #42

Merged
merged 1 commit into from
Jun 6, 2013

Conversation

kcharwood
Copy link
Contributor

The gesture completion block is not being called when the center UIViewController is panned all the way to the left side. If you release your finger from the screen, while panning to the left, before the center view reaches the left side, then the gesture completion block will be executed.

Exposing the left view by panning the center view all the way to the right side of the screen will, correctly, as result the gesture completion block to be executed.

@kcharwood
Copy link
Contributor

Hmm I am not able to reproduce this one.

I am trying to do this:

  1. Start panning the center view to the left (exposing the right drawer controller)
  2. Pan the center view to the left, but don't go all the way to the max right drawer width
  3. Lift up my finger to stop the pan, and see that animation complete

When the animation completes, I see the callback block.

@filipslavik
Copy link
Author

Hi Kevin,

my project has no right drawer controller. To reproduce, try to do this :

  1. Toggle the drawer to expose the left drawer controller
  2. Start panning the center view to the left and don't lift up your finger until the center view covers entirely the left drawer
  3. The callback block won't be executed

@kcharwood
Copy link
Contributor

Excellent thanks for those steps. I can repro that. Let me take a look.

We weren't calling the completion block if no side was currently open.
@kcharwood
Copy link
Contributor

It looks like we weren't calling the completion block when no side was currently open. This pull request here should fix that.

@larsacus take a look.

@larsacus
Copy link
Contributor

larsacus commented Jun 6, 2013

Hmm interesting. Fix looks good.

kcharwood added a commit that referenced this pull request Jun 6, 2013
Fixed Gesture completion block not executed when panning to the left (until the end of screen)
@kcharwood kcharwood merged commit 5f59b3f into master Jun 6, 2013
@kcharwood
Copy link
Contributor

Thanks @filipslavik

This fix is in master now. I'll try and get a 0.2.1 pushed later in the weekend when I make sure there are no other pressing issues that come up from the 0.2.0 release.

@kcharwood
Copy link
Contributor

Sorry for the delay. I just revved the repo, and submitted a 0.2.1 pod to Cocoapods. Should be available later today.

@kcharwood kcharwood deleted the gesture_completion_fix branch August 12, 2013 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants