State restoration #69
Conversation
…… …ore state MMDrawerController can restore: - leftDrawerViewController - rightDrawerViewController - centerViewController - openSide
|
References #65 |
|
@djibouti33 Would you want to take a stab updating the example to use this? |
|
Yeah, absolutely. Unfortunately I'm taking off for vacation in about 45 minutes but I can definitely get to that when I return. Are you ok with keeping this branch around until after 8/12? |
|
Sure. I may get it tackled before you get back. Enjoy the vacation. |
- encoding/decoding seems to be occurring in the proper steps - centerViewController is not appearing - Unbalanced calls to begin/end appearance transitions for <MMExampleRightSideDrawerViewController:> begin logged in console
|
I took a stab at it with b850b8d. Not sure if I'm doing it right, but it appears to be "working". |
|
I've decided to not automatically set the |
- still not working:
- scroll position of center table is not being restored. could have something to do with the fact that this is a UITableViewController. simpy setting a restorationIdentifier on the tableView had no effect, even though it should
- drawerWidths are being restored (the checkmark restores to the proper dimension) but then the drawer pops out to it's initial width.
|
I've merged it my branch from 22adcbd that pulled in some of your original changes. It appears to be working well for me. Take a look, and feel free to make any additional changes. If you like what you see, we'll call it done :) Getting close to being ready for an 0.4.0 release (maybe later today?) Thanks again for kicking this off 🍻 |
|
Awesome! Are you ok with the two limitations I noted in my latest commit? About the drawer widths and the center table not maintaining scroll state? I'm away from a computer today so won't be able to look over everything until Sunday night. If your eager to cut 0.4.0 I'd say go ahead, otherwise we can just include it in the next. From: Kevin Harwood [notifications@github.com] I've merged it my branch from 22adcbdhttps://github.com/mutualmobile/MMDrawerController/commit/22adcbd that pulled in some of your original changes. It appears to be working well for me. Take a look, and feel free to make any additional changes. If you like what you see, we'll call it done :) Getting close to being ready for an 0.4.0 release (maybe later today?) Thanks again for kicking this off [https://github.global.ssl.fastly.net/images/icons/emoji/beers.png] — |
Enabling an instance of MMDrawerController to restore it's left, right and center view controllers as well as state pertaining to any openSide when app was sent to background.