Improve README #31
Merged
Improve README #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jonas
commented
Jun 3, 2018
jonas
commented
- Fix typos
- json -> JSON
- Indent code examples
- Simplify text
- Fix typos - json -> JSON - Indent code examples - Simplify text
|
The irony of having a typo in the message of a commit that claims to fix typos. 🤦♂️ |
jonas
commented
Jun 3, 2018
| @@ -120,14 +117,11 @@ graphqlProductionSchema := GraphQLSchemaLoader | |||
| .loadSchema() | |||
| ``` | |||
|
|
|||
| The introspection query doesn't support headers at this moment, but will be added | |||
| soon. | |||
There was a problem hiding this comment.
The .withHeaders(...) code in the example above suggests that this is fixed.
|
|
||
| SBT plugin to generate and validate graphql schemas written with Sangria. | ||
|
|
||
| See also: https://github.com/mediative/sangria-codegen |
There was a problem hiding this comment.
Nothing to see there, since the code generator was integrated and cleaned up in this plugin.
| @@ -1,12 +1,9 @@ | |||
|
|
|||
| # sbt-graphql [](https://travis-ci.org/muuki88/sbt-graphql) [  ](https://bintray.com/sbt/sbt-plugin-releases/sbt-graphql/_latestVersion) | |||
|
|
|||
| > This plugin is an experiment at this moment. | |||
| > SBT 1.x only | |||
| > This plugin is sbt 1.x only and experimental. | |||
There was a problem hiding this comment.
Flipped so it puts more equal weight on the two caveats.
| hero { | ||
| name | ||
| } | ||
| }""" |
There was a problem hiding this comment.
Copied from the expected test output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.