-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate conditional transitions by majkrzak #44
base: main
Are you sure you want to change the base?
Conversation
Thank you for taking care of it. I sadly had not enough time to continue it. |
for input in config[CONF_INPUTS_KEY]: | ||
if CONF_INPUT_TRANSITIONS_KEY in input: | ||
for transition in input[CONF_INPUT_TRANSITIONS_KEY]: | ||
graph_data = graph_data + f" {transition[CONF_FROM]} --> {transition[CONF_TO]}: {input[CONF_NAME]}{os.linesep}" | ||
# TODO: significant duplicated code with the DOT graph? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking to removing the DOT graph support and only using Mermaid format. This would reduce code duplication and effort to support this
Apologies to not responding earlier. I don't have much time to contribute to this, but do intend to get this PR merged eventually. |
I could maybe take a look at it at some point! I haven't been doing much with ESPHome lately, so I'm not sure I'll get around to it. I've been moving to a custom alternative I'm calling ArduinoCogs, because ESPHome still doesn't seem to be very focused on low power for battery devices, so it's not a super high priority for me at the moment even though it's still a wonderful project. |
Building on work by @majkrzak and adding logic to try to nicely format the charts outputs while including the conditions.