Skip to content

Commit

Permalink
feat: remove deprecated .hls and .video props
Browse files Browse the repository at this point in the history
Please use ._hls for hls.js access if you must and use .media instead of
.video for consistency.

BREAKING CHANGE: remove deprecated .hls and .video props.
  • Loading branch information
Gary Katsevman committed Sep 21, 2022
1 parent 8da36d6 commit 7ed61db
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 32 deletions.
8 changes: 0 additions & 8 deletions packages/mux-audio/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,6 @@ class MuxAudioElement extends CustomAudioElement<HTMLAudioElement> implements Pa
return playerSoftwareVersion;
}

/**
* @deprecated please use ._hls instead
*/
get hls(): PlaybackEngine | undefined {
console.warn('<mux-audio>.hls is deprecated, please use ._hls instead');
return this._hls;
}

get _hls(): PlaybackEngine | undefined {
return this.__hls;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/mux-player/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -582,14 +582,6 @@ class MuxPlayerElement extends VideoApiElement {
return this.#state.inLiveWindow;
}

/**
* @deprecated please use ._hls instead
*/
get hls(): PlaybackEngine | undefined {
logger.warn('<mux-player>.hls is deprecated, please use ._hls instead');
return this._hls;
}

get _hls(): PlaybackEngine | undefined {
return this.media?._hls;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/mux-player/src/video-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,6 @@ class VideoApiElement extends globalThis.HTMLElement implements VideoApiElement
return this.shadowRoot?.querySelector('mux-video');
}

/**
* @deprecated please use .media instead
*/
get video(): MuxVideoElementExt | null | undefined {
logger.warn('<mux-player>.video is deprecated, please use .media instead');
return this.media;
}

get paused() {
return this.media?.paused ?? true;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/mux-video/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,6 @@ class MuxVideoElement extends CustomVideoElement<HTMLVideoElement> implements Pa
this.__playerSoftwareVersion = value;
}

/**
* @deprecated please use ._hls instead
*/
get hls(): PlaybackEngine | undefined {
console.warn('<mux-video>.hls is deprecated, please use ._hls instead');
return this._hls;
}

get _hls(): PlaybackEngine | undefined {
return this.__hls;
}
Expand Down

0 comments on commit 7ed61db

Please sign in to comment.