Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Unable to style rendition and playback-rate menus #1065

Closed
1 task done
theazgra opened this issue Jan 22, 2025 · 0 comments · Fixed by #1066 or #1057
Closed
1 task done

Bug: Unable to style rendition and playback-rate menus #1065

theazgra opened this issue Jan 22, 2025 · 0 comments · Fixed by #1066 or #1057
Assignees
@luwes

Comments

@theazgra
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player

Which browsers are you using?

Edge ("Edgeium")

Which operating systems are you using?

Windows

Description

Prior to version 3.2.x, (we were using 2.4.1) the rendition menu and playback-rate menu could have been styled using part selector like this:

&::part(bottom rendition listbox) {
  // some styles
}
&::part(bottom playback-rate listbox) {
  // some styles
}

Now, in current version listbox part got changed to menu, but menu part is not found in exportparts

Image

Reduced test case

No response

Steps to reproduce

1.Install newest version like 3.2.5-canary.3
2. Try to style rendition menu

Current Behavior

menu part is not exported

Expected Behavior

menu part will be exported for styling

Errors

No response

What version of the package are you using?

3.2.5-canary.3
@theazgra theazgra added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Jan 22, 2025
@luwes luwes removed bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Jan 29, 2025
@luwes luwes mentioned this issue Jan 29, 2025
Merged
luwes added a commit to luwes/elements that referenced this issue Jan 29, 2025
@luwes
fix: add missing menu part
efc64cd 
fix muxinc#1065
@luwes luwes self-assigned this Jan 29, 2025
@luwes luwes closed this as completed in f5c6d90 Feb 13, 2025
@github-actions github-actions bot mentioned this issue Feb 13, 2025
Merged
luwes pushed a commit that referenced this issue Feb 13, 2025
@github-actions
chore: release main (#1057)
c620c3e 
🤖 I have created a release *beep* *boop*
---


<details><summary>@mux/mux-active-viewer-count: 0.2.0-alpha.12</summary>

##
[0.2.0-alpha.12](https://github.com/muxinc/elements/compare/@mux/mux-active-viewer-count@0.2.0-alpha.11...@mux/mux-active-viewer-count@0.2.0-alpha.12)
(2025-02-13)


### Bug Fixes

* upgrade MC, fix theme flicker
([#1067](#1067))
([b2fad06](b2fad06))
</details>

<details><summary>@mux/playback-core: 0.28.3</summary>

##
[0.28.3](https://github.com/muxinc/elements/compare/@mux/playback-core@0.28.2...@mux/playback-core@0.28.3)
(2025-02-13)


### Bug Fixes

* **playback-core:** Update hls.js version to fix multi-DRM playready
bug. ([#1060](#1060))
([380ded2](380ded2))
* upgrade MC, fix theme flicker
([#1067](#1067))
([b2fad06](b2fad06))
</details>

<details><summary>@mux/mux-player: 3.3.0</summary>

##
[3.3.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.2.4...@mux/mux-player@3.3.0)
(2025-02-13)


### Features

* implement Mux badge
([#988](#988))
([2343df8](2343df8))


### Bug Fixes

* add missing menu part
([#1066](#1066))
([f5c6d90](f5c6d90)),
closes [#1065](#1065)
* Mux-player imports
([#1056](#1056))
([9b7ec1b](9b7ec1b))
* **playback-core:** Update hls.js version to fix multi-DRM playready
bug. ([#1060](#1060))
([380ded2](380ded2))
* upgrade MC, fix theme flicker
([#1067](#1067))
([b2fad06](b2fad06))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-video bumped from 0.24.2 to 0.24.3
    * @mux/playback-core bumped from 0.28.2 to 0.28.3
</details>

<details><summary>@mux/mux-player-react: 3.3.0</summary>

##
[3.3.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.2.4...@mux/mux-player-react@3.3.0)
(2025-02-13)


### Features

* implement Mux badge
([#988](#988))
([2343df8](2343df8))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-player bumped from 3.2.4 to 3.3.0
    * @mux/playback-core bumped from 0.28.2 to 0.28.3
</details>

<details><summary>@mux/mux-audio: 0.15.3</summary>

##
[0.15.3](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.2...@mux/mux-audio@0.15.3)
(2025-02-13)


### Bug Fixes

* **playback-core:** Update hls.js version to fix multi-DRM playready
bug. ([#1060](#1060))
([380ded2](380ded2))
* upgrade MC, fix theme flicker
([#1067](#1067))
([b2fad06](b2fad06))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.2 to 0.28.3
</details>

<details><summary>@mux/mux-audio-react: 0.15.3</summary>

##
[0.15.3](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.2...@mux/mux-audio-react@0.15.3)
(2025-02-13)


### Miscellaneous Chores

* **@mux/mux-audio-react:** Synchronize audio versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.2 to 0.28.3
</details>

<details><summary>@mux/mux-video: 0.24.3</summary>

##
[0.24.3](https://github.com/muxinc/elements/compare/@mux/mux-video@0.24.2...@mux/mux-video@0.24.3)
(2025-02-13)


### Bug Fixes

* **playback-core:** Update hls.js version to fix multi-DRM playready
bug. ([#1060](#1060))
([380ded2](380ded2))
* upgrade MC, fix theme flicker
([#1067](#1067))
([b2fad06](b2fad06))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.2 to 0.28.3
</details>

<details><summary>@mux/mux-video-react: 0.24.3</summary>

##
[0.24.3](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.24.2...@mux/mux-video-react@0.24.3)
(2025-02-13)


### Miscellaneous Chores

* **@mux/mux-video-react:** Synchronize video versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.2 to 0.28.3
</details>

<details><summary>@mux/mux-uploader: 1.1.2</summary>

##
[1.1.2](https://github.com/muxinc/elements/compare/@mux/mux-uploader@1.1.1...@mux/mux-uploader@1.1.2)
(2025-02-13)


### Bug Fixes

* upgrade MC, fix theme flicker
([#1067](#1067))
([b2fad06](b2fad06))
</details>

<details><summary>@mux/mux-uploader-react: 1.1.2</summary>

##
[1.1.2](https://github.com/muxinc/elements/compare/@mux/mux-uploader-react@1.1.1...@mux/mux-uploader-react@1.1.2)
(2025-02-13)


### Miscellaneous Chores

* **@mux/mux-uploader-react:** Synchronize uploader versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-uploader bumped from 1.1.1 to 1.1.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luwes luwes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing menu part luwes/elements
chore: release main muxinc/elements
2 participants
@luwes @theazgra