Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated .hls and .video props #408

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

gkatsev
Copy link
Contributor

@gkatsev gkatsev commented Sep 21, 2022

Please use ._hls for hls.js access if you must and use .media instead of .video for consistency.

BREAKING CHANGE: remove deprecated .hls and .video props.

Please use ._hls for hls.js access if you must and use .media instead of
.video for consistency.

BREAKING CHANGE: remove deprecated .hls and .video props.
@gkatsev gkatsev requested a review from a team as a code owner September 21, 2022 19:06
@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 7:07PM (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 7:07PM (UTC)
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 7:07PM (UTC)
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 7:07PM (UTC)
elements-demo-vue ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 7:07PM (UTC)

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #408 (7ed61db) into main (8da36d6) will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   80.08%   80.58%   +0.49%     
==========================================
  Files          38       38              
  Lines        4972     4940      -32     
  Branches      169      168       -1     
==========================================
- Hits         3982     3981       -1     
+ Misses        981      950      -31     
  Partials        9        9              
Impacted Files Coverage Δ
packages/mux-audio/src/index.ts 63.20% <ø> (+1.55%) ⬆️
packages/mux-player/src/index.ts 68.33% <ø> (+0.52%) ⬆️
packages/mux-player/src/video-api.ts 77.77% <ø> (+1.53%) ⬆️
packages/mux-video/src/index.ts 62.55% <ø> (+1.14%) ⬆️

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gkatsev gkatsev merged commit 2bd4861 into muxinc:main Sep 21, 2022
@gkatsev gkatsev deleted the remove-hls-prop branch September 21, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants