Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parts to video and audio, run all builds on dev #199

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Add parts to video and audio, run all builds on dev #199

merged 2 commits into from
Apr 26, 2022
+15 −6

Conversation

gkatsev
Copy link
Contributor

@gkatsev gkatsev commented Apr 25, 2022 •
edited
Loading

The part attributes for mux-video and mux-audio fix #125.

@vercel
Copy link

vercel bot commented Apr 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 10:24PM (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 10:24PM (UTC)
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 10:24PM (UTC)
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 10:24PM (UTC)
elements-demo-vue ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 10:24PM (UTC)

@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #199 (bb6d494) into main (d6078b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          35       35           
  Lines        3717     3717           
  Branches      135      135           
=======================================
  Hits         3058     3058           
  Misses        653      653           
  Partials        6        6
Impacted Files Coverage Δ
packages/mux-audio/src/CustomAudioElement.js 89.91% <100.00%> (ø)
packages/mux-video/src/CustomVideoElement.js 96.53% <100.00%> (ø)

cjpillsbury
cjpillsbury approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

luwes
luwes reviewed Apr 26, 2022
View reviewed changes
packages/mux-video/src/CustomVideoElement.js
@@ -33,7 +33,7 @@ template.innerHTML = `

</style>

<video crossorigin></video>
<video part="video" crossorigin></video>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

luwes
luwes approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gkatsev gkatsev merged commit 49e5b6f into muxinc:main Apr 26, 2022
@gkatsev gkatsev deleted the video-audio-parts branch April 26, 2022 15:37
@balexand
Copy link

balexand commented May 7, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luwes luwes luwes approved these changes

@cjpillsbury cjpillsbury cjpillsbury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: No way to style <video> element inside <mux-video>
4 participants
@gkatsev @balexand @luwes @cjpillsbury